r311: Cherry-pick memberlist debounce PR from dskit #9715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seizethedave
changed the title
seizethedave
requested review from
stevesg,
grafanabot,
a team and
tacole02
as code owners
tacole02
approved these changes
Oct 22, 2024
| @@ -2959,6 +2959,11 @@ The `memberlist` block configures the Gossip memberlist. | |||
| # CLI flag: -memberlist.compression-enabled | |||
| [compression_enabled: <boolean> | default = true] | |||
|
|
|||
| # (advanced) How frequently to notify watchers when a key changes. Can reduce | |||
| # CPU activity in large memberlist deployments. 0 to notify without delay. | |||
There was a problem hiding this comment.
Suggested change
| # CPU activity in large memberlist deployments. 0 to notify without delay. | |
| # CPU activity in large member list deployments. Set to `0` to notify without delay. |
There was a problem hiding this comment.
Thank you- I’ll make these changes on the main branch. If I make them here no one will ever see them. 😺
charleskorn
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is a manual quasi-backport to obtain grafana/dskit#592 which is cherry-picked into dskit's r311 branch. It is turned off unless explicitly configured.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.