Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IngesterInstanceHasNoTenants alert: exclude read only replicas #9843

Merged

Conversation

colega
Copy link
Contributor

@colega colega commented Nov 6, 2024

What this PR does

It's expected that read-only ingesters might not have tenants, there's no need to alert on that.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

It's expected that read-only ingesters might not have tenants, there's no need to alert on that.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega marked this pull request as ready for review November 6, 2024 11:18
@colega colega requested a review from a team as a code owner November 6, 2024 11:18
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@colega colega merged commit 6bf0b93 into main Nov 6, 2024
31 checks passed
@colega colega deleted the ingesterinstancehasnotenants-alert-exclude-read-only-replicas branch November 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants