Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag #9981

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

codesome
Copy link
Member

What this PR does

NOTE: this is going to r315 first because it is mainly needed for this release right now. Will be backported to main and other releases later.

Adds a flag to enable the feature added in #9979

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@codesome codesome requested review from tacole02 and a team as code owners November 21, 2024 19:22
pkg/storage/tsdb/config.go Outdated Show resolved Hide resolved
codesome and others added 2 commits November 21, 2024 14:51
Co-authored-by: chencs <casie.chen@grafana.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@codesome codesome enabled auto-merge (squash) November 21, 2024 20:04
@codesome codesome merged commit 23f9fb6 into r315 Nov 21, 2024
29 checks passed
@codesome codesome deleted the codesome/r315-flag branch November 21, 2024 20:08
codesome added a commit that referenced this pull request Nov 27, 2024
…ag (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
codesome added a commit that referenced this pull request Nov 27, 2024
…flag (#10035)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035) (#10091)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035) (#10092)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035) (#10090)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants