-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag #9981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
chencs
reviewed
Nov 21, 2024
56quarters
approved these changes
Nov 21, 2024
Co-authored-by: chencs <casie.chen@grafana.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
added a commit
that referenced
this pull request
Nov 27, 2024
…ag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com>
codesome
added a commit
that referenced
this pull request
Nov 27, 2024
…flag (#10035) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com>
codesome
added a commit
that referenced
this pull request
Dec 2, 2024
…flag (#10035) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> (cherry picked from commit 832d02b)
codesome
added a commit
that referenced
this pull request
Dec 2, 2024
…flag (#10035) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> (cherry picked from commit 832d02b)
codesome
added a commit
that referenced
this pull request
Dec 2, 2024
…flag (#10035) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> (cherry picked from commit 832d02b)
codesome
added a commit
that referenced
this pull request
Dec 2, 2024
…flag (#10035) (#10091) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> (cherry picked from commit 832d02b)
codesome
added a commit
that referenced
this pull request
Dec 2, 2024
…flag (#10035) (#10092) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> (cherry picked from commit 832d02b)
codesome
added a commit
that referenced
this pull request
Dec 2, 2024
…flag (#10035) (#10090) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag (#9981) * Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Update pkg/storage/tsdb/config.go Co-authored-by: chencs <casie.chen@grafana.com> * Make flag experimental Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * CHANGELOG Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: chencs <casie.chen@grafana.com> (cherry picked from commit 832d02b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
NOTE: this is going to r315 first because it is mainly needed for this release right now. Will be backported to main and other releases later.
Adds a flag to enable the feature added in #9979
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.