fix incorrectly set query frontend codec lookback delta #9984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoposa
force-pushed
the
francoposa/fix-query-frontend-codec-intialization
branch
from
7951bb2 to
028b10b
Compare
aldernero
approved these changes
Nov 21, 2024
francoposa
deleted the
francoposa/fix-query-frontend-codec-intialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This appears to have been a bug ever since I plugged the setting into the prometheus codec.
It should be set directly from the querier engine config.
The frontend v2 config also sets it from the original source, the querier engine config. Since this codec module gets initialized before the frontend v2 config setting does, by referencing the uninitialized config value, it always ends up zero instead of the real value.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.