Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or Description for Schedules Rotations #1460

Closed
Mazizieh opened this issue Mar 6, 2023 · 2 comments
Closed

Rename or Description for Schedules Rotations #1460

Mazizieh opened this issue Mar 6, 2023 · 2 comments

Comments

@Mazizieh
Copy link

Mazizieh commented Mar 6, 2023

In Grafana Oncall, cloud and I beleive open source version as well, there is no way to rename or add a description for Schedules Rotations.

Added rotations are having default names like L-1-1 and those a names can't be changed or at least having a description, like a GMT rotation or anything else.

Grafana

@Konstantinov-Innokentii
Copy link
Member

Moved to "in progress", since web and terraform uses different name fields which will lead to confusion. Ideally we want to show name from terraform in web and most importantly do not have two sources of truth for actual shift title.

@Konstantinov-Innokentii
Copy link
Member

Konstantinov-Innokentii commented May 2, 2023

Opened a PR with backend.
Now shift has a "name" field. When it's null frontend can show some default name (Lx-y Rotation), but send new name value if user modifies it.
It is done because there is no way of defining y in "Lx-y Rotation" on backend while migrating.
However, I'm not sure how frontend calculates y. Or maybe we can include inly x in rotation title? Going to discuss it with @maskin25 when he will be back from PTO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants