Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release schedule v2 bug collection #2118

Closed
Matvey-Kuk opened this issue Jun 7, 2023 · 26 comments
Closed

Pre-release schedule v2 bug collection #2118

Matvey-Kuk opened this issue Jun 7, 2023 · 26 comments
Labels
part:schedules

Comments

@Matvey-Kuk
Copy link
Contributor

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅

  1. Schedule list, "Oncall" -> "On-call now"
Screenshot 2023-06-07 at 12 19 44

✅
2) New schedule, "Additional notification settings" -> "Notification settings"
Screenshot 2023-06-07 at 12 20 48

✅
3) Top nav stick to the top of the schedule screen:
Screenshot 2023-06-07 at 12 25 33

✅
4) Didn't we update texts here? I think we agreed on "Delete past shifts".
Screenshot 2023-06-07 at 12 26 53

✅
5) "Add rotation to the schedule to see users" -> "Add rotation to see users"
Screenshot 2023-06-07 at 12 59 17
@raphael-batte
Copy link

raphael-batte commented Jun 7, 2023 •
edited by maskin25
Loading

❓
There are white visual artefacts in the modal
image

@raphael-batte
Copy link

raphael-batte commented Jun 7, 2023 •
edited by maskin25
Loading

✅
Show warning when user tries to save rotation without users. Modal shouldn't closes.

@raphael-batte
Copy link

raphael-batte commented Jun 7, 2023 •
edited by maskin25
Loading

❓

Sometimes dropdown with recurrence option is empty
image

@raphael-batte
Copy link

raphael-batte commented Jun 7, 2023 •
edited by maskin25
Loading

✅

Week start settings and days arrangement in the modal should be the same
image

@Ferril
Copy link
Member

Ferril commented Jun 7, 2023 •
edited by maskin25
Loading

✅

Some weird prerendered shifts behavior when opening update shift window
Screenshot 2023-06-07 at 12 11 47
(pressed on the first shift and rotation broke)
Screenshot 2023-06-07 at 12 12 24
After pressing "update" shift was moved forward to 06.06 but the start date is 05.06

Screenshot 2023-06-07 at 12 17 50

@Matvey-Kuk Matvey-Kuk changed the title New schedule bug hunt collection Pre-release schedule v2 bug hunt collection Jun 7, 2023
@Matvey-Kuk Matvey-Kuk changed the title Pre-release schedule v2 bug hunt collection Pre-release schedule v2 bug collection Jun 7, 2023
@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅

Use-cases for repeters:

Grafana-style rotation 8-8-8:
Recurrence period: 1 week
Mask by weekdays: Mo, Tu, We, Th, Fr
Limit each shift length: 8h
People:
Group 1: [Alex]
Group 2: [Bob]

Expected outcome:
Week 1:
Mo | Tu | We | Th | Fr | St | Su |
[Alex, 8h] | [Alex, 8h] | [Alex, 8h] | [Alex, 8h] | [Alex, 8h]
Week 2:
Mo | Tu | We | Th | Fr | St | Su |
[Bob, 8h] | [Bob, 8h] | [Bob, 8h] | [Bob, 8h] | [Bob, 8h]

✅

Customer's daily rotation 8h:
Recurrence period: 1 day
Mask by weekdays: Mo, Tu, We, Th, Fr
Limit each shift length: 8h
People:
Group 1: [Alex]
Group 2: [Bob]

Expected outcome:
Week 1:
Mo | Tu | We | Th | Fr | St | Su |
[Alex, 8h] | [Bob, 8h] | [Alex, 8h] | [Bob, 8h] | [Alex, 8h]
Week 2:
Mo | Tu | We | Th | Fr | St | Su |
[Bob, 8h] | [Alex, 8h] | [Bob, 8h] | [Alex, 8h] | [Bob, 8h]

@Ferril
Copy link
Member

Ferril commented Jun 7, 2023 •
edited by maskin25
Loading

✅

Grafana-style rotation doesn't work correctly.
test timezone - timezone GTM+2
In this example rotation starts on Monday, user - Matias. On Tuesday user changes to Maxim. Next week starts with Maxim and changes to Matias.
Screenshot 2023-06-07 at 12 44 07
Screenshot 2023-06-07 at 12 44 15

On open shift edit window, chosen weekdays are different
Screenshot 2023-06-07 at 13 00 46

It doesn't affect real shifts. But if you rename the rotation, weekdays of shifts will change
Screenshot 2023-06-07 at 13 03 27

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅

Also reproducing: #2048

@raphael-batte
Copy link

raphael-batte commented Jun 7, 2023 •
edited by maskin25
Loading

✅

Hide working hours in user's blocks in case recurrence period more than 1 week
image

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅

Also not fixed: #1820

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅

This release will close: #1508

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

This release will close: #2118

DUPLICATE

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅

This release will close: #1505

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅
This release will close: #1462

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅
This release will close: #1460

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 7, 2023 •
edited by maskin25
Loading

✅
Also not fixed: #1433

This was referenced Jun 7, 2023
Merged
Merged
maskin25 pushed a commit that referenced this issue Jun 9, 2023
@matiasb
Require users before creating/updating shift (#2142)
e932d00 
Related to
#2118 (comment)
matiasb added a commit that referenced this issue Jun 13, 2023
@matiasb
Update shift week_start when translating to UTC (#2124)
6e5d417 
This fixes scenario described
[here](#2118 (comment)).

When a rotation is setup in UTC+1, and the shift starts at 00:00 with
Monday as active day and a weekly frequency, the values are translated
to UTC when submitting to the backend, so the shift data becomes
something like: shift starting at 23:00 on Sunday, but since week_start
is on Monday, the "first event" in the week belongs to the "previous
week". This can be addressed by moving the week_start, so a weekly shift
that was starting on a Monday but in UTC tz starts on Sunday,
"translates" to a UTC week_start on Sunday:


![rotation-example](https://github.com/grafana/oncall/assets/260710/5222d3ce-52b7-41d5-8ecb-d01c7a0139cb)


(this is with the proposed changes; otherwise you get the same issue
linked above where the first event in the week is assigned to the other
user group).

About selected week days changed when editing a rotation, see inline
comment (related to
[this](#1322 (comment)))
@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 15, 2023 •
edited by maskin25
Loading

✅

Magic with Monday when my first day is Sunday:

Screen.Recording.2023-06-15.at.14.44.23.mov

@Matvey-Kuk
Copy link
Contributor Author

Matvey-Kuk commented Jun 15, 2023 •
edited by maskin25
Loading

✅

Boolean filters doesn't stay in the same state after getting back from the schedule:

Screen.Recording.2023-06-15.at.14.48.18.mov

@raphael-batte
Copy link

raphael-batte commented Jun 15, 2023 •
edited by maskin25
Loading

❓

Still have visual artefacts in rotation creation modal (Chrome Version 114.0.5735.90 (Official Build) (arm64))
image

Looks like they are connected to overflow: scroll parameter
image

@raphael-batte
Copy link

raphael-batte commented Jun 15, 2023 •
edited by maskin25
Loading

❌ z-index battle, won't fix atm

When user creates override from shift, tooltip should be below the modal.
image

@raphael-batte
Copy link

raphael-batte commented Jun 15, 2023 •
edited by maskin25
Loading

✅
Rotation renaming doesn't work.

@raphael-batte
Copy link

raphael-batte commented Jun 15, 2023 •
edited by maskin25
Loading

❓
When we move courser over rotation title, modal header twitches.

Screen.Recording.2023-06-15.at.14.17.46.mov

@raphael-batte
Copy link

raphael-batte commented Jun 15, 2023 •
edited by maskin25
Loading

✅

Rotation creation modal polishing.

  • add close icon (х) to the top right corner
  • remove Close button from the bottom to increase space for TZ data.

image

@raphael-batte
Copy link

raphael-batte commented Jun 15, 2023 •
edited by maskin25
Loading

✅

Labels are broken.

  1. Escalations and warning labels inside should have an icons
  2. Escalations label should be green
    image
    image

@matiasb matiasb mentioned this issue Jun 15, 2023
Merged
matiasb added a commit that referenced this issue Jun 16, 2023
@matiasb
Update daily shifts by day to handle changed week start (#2263)
9146199 
Related to
#2118 (comment)
@matiasb
Copy link
Contributor

matiasb commented Jun 16, 2023

✅
This release will close #1322

@matiasb
Copy link
Contributor

matiasb commented Jun 26, 2023

I guess we can close this one? Let's open new issues for new bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:schedules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matiasb @Matvey-Kuk @Ferril @raphael-batte