-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing user details when editing a rotation #1820
Comments
This is still happening (https://github.com/grafana/support-escalations/issues/9265) |
@matiasb the issue is that editors get 403 when try to fetch admins user data, is it by design? In my local experiment editors.are.not.able.to.fetch.admins.user.data.mov |
Right, that's a possible issue. At some point we introduced a new schedule endpoint to get user information from there instead of requesting explicit user details. In any case, let me check for a work-around on the permission side which can be a simpler short-term solution (and eventually we can work on the frontend side to not require hitting the user details API?) |
let's first check why editors can't load admin's profiles, then start switching to the new schedule endpoint |
Related to #1820 Editor and Viewer roles have the user-settings:read permission, which allows them to list users but with some of the data hidden. It makes sense to allow the same thing for the detail endpoint, keeping the viewable data restriction (fixing the referenced issue too).
[@maskin] all done, we need to check if it works |
When updating as Editor a schedule in an organization with multiple users ( > 100), final schedule is displaying all users information (per #999), but we are still missing user details for users not available in that first page when editing the rotation:
Maybe we should get information for users in a schedule (which are usually not all users from an organization) from a specific schedule endpoint instead of the general user listing?
The text was updated successfully, but these errors were encountered: