-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile push message is not taken from the template #2050
Comments
@greatvovan thanks a lot for the suggestions! I totally agree with your feedback and we're already working on templates for mobile push notifications. I agree with your suggested solutions as well and we'll take them into consideration for the default template! |
@iskhakov what's the status of this? just curious. i assume priority for this is rather low. thanks :) |
Curious about that also :) |
The team will work on this later, it got pulled out of the short-term backlog :( |
# What this PR does Closes #2050 https://www.loom.com/share/cca9af04f905456087f25e9cbf1845ab ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
While the title and the message in the mobile app or controlled be templates of "Web" type, the push message itself is using different template, which is not under user's control.
Currently a push message looks as follows:
Grafana Alerting integration type:
Webhook integration type:
Reproducing
Title
, Message:Message
.Title
, Message:Message
.Payload
curl $url -H 'Content-Type: application/json' -d @$HOME/Downloads/oncall.json
Expected behaviour:
Push message uses the configured text templates (in our case "Tittle" and "Message").
Actual behaviour:
Suggested solution
Push text must include the configured title.
Rationale: only the user knows how to compose a useful message from the payload. Integration name and alert name might be not specific. "Incident via Integration name" may provide zero information. Looking at how other applications do the same, they try to fit as much information as possible into the push message.
Example:
Status: Firing, alerts: <count>
row is also questionable. Are we sending pushes about "Acknowledged" or other status? If yes, then keep it.System information
The text was updated successfully, but these errors were encountered: