Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pagination state to filters #2931

Closed
teodosii opened this issue Aug 31, 2023 · 0 comments
Closed

Move pagination state to filters #2931

teodosii opened this issue Aug 31, 2023 · 0 comments
Assignees
@teodosii
Labels
bug Something isn't working involved:Frontend

Comments

@teodosii
Copy link
Member

teodosii commented Aug 31, 2023 •
edited
Loading

Right now the pagination is stored separately for each page (alert gorups, schedules and so on). With the last iteration on Integration tweaks we migrated the pagination to the store, but the remaining is to do the same for all remaining pages and let the pagination live in the filters instead of the global store.
@teodosii teodosii added the bug Something isn't working label Aug 31, 2023
@teodosii teodosii self-assigned this Aug 31, 2023
@teodosii teodosii mentioned this issue Oct 27, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
@teodosii
Pagination refactoring/cleanup (#3205)
871860c 
# What this PR does

- Pagination cleanup so that frontend no longer hardcodes page size
- Moved pagination to the filters store instead for all pages that have
pagination enabled
- Prevent UI triggering polling if window is inactive or if the previous
request didn't complete

## Which issue(s) this PR fixes

#2931 
#2462

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
brojd pushed a commit that referenced this issue Sep 18, 2024
@teodosii
Pagination refactoring/cleanup (#3205)
6693ed6 
# What this PR does

- Pagination cleanup so that frontend no longer hardcodes page size
- Moved pagination to the filters store instead for all pages that have
pagination enabled
- Prevent UI triggering polling if window is inactive or if the previous
request didn't complete

## Which issue(s) this PR fixes

#2931 
#2462

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodosii teodosii

Labels
bug Something isn't working involved:Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teodosii