Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE_TELEGRAM_INTEGRATION_ENABLED doesn't affect telegram UI #319

Closed
mothershipper opened this issue Aug 1, 2022 · 1 comment
Closed

FEATURE_TELEGRAM_INTEGRATION_ENABLED doesn't affect telegram UI #319

mothershipper opened this issue Aug 1, 2022 · 1 comment
Assignees
@Ukochka
Labels
bug Something isn't working involved:Frontend

Comments

@mothershipper
Copy link
Contributor

We've attempted to disable the telegram integration by setting this to False on both the engine and celery worker deployments. But we're still seeing the telegram verification warning in the UI for our end-users:

Screen Shot 2022-07-29 at 1 16 57 PM

Initial thought is that perhaps Telegram should be hidden entirely in the UI if the feature flag is disabled, but even if the feature is enabled, should the plugin show a warning to end users if the admins have not configured the telegram integration?

If I find some time this weekend, I can poke around at this and see what a fix might entail. If someone else gets to it before me, it'd be greatly appreciated :)
@raphael-batte raphael-batte added the bug Something isn't working label Aug 2, 2022
@Matvey-Kuk
Copy link
Contributor

@mothershipper thank you for the bug report! The issue should be easy to fix, but most of core team FEs are on PTO now so feel free to hack the solution :)

@Ukochka Ukochka mentioned this issue Feb 28, 2023
Merged
brojd pushed a commit that referenced this issue Sep 18, 2024
@Ukochka
319 telegram warning bug (#1424)
08114fd 
# What this PR does
When you disable Telegram feature we did not handle it in our frontend.
Now if the fieture is disabled we do not shoe Telegram at Chat-ops, at
Users.
Also some crarification was added to the instructions that discussion
group should be unique for each channel

## Which issue(s) this PR fixes
#319
#938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ukochka Ukochka

Labels
bug Something isn't working involved:Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maskin25 @Matvey-Kuk @Ukochka @mothershipper @raphael-batte