Change wording from "incident" to "alert group" in the Telegram app #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstpme
commented
Dec 29, 2022
| @@ -20,7 +20,7 @@ class TelegramMessage(models.Model): | |||
| (ACTIONS_MESSAGE, "Actions message"), | |||
| (LOG_MESSAGE, "Log message"), | |||
| (FORMATTING_ERROR, "Alert can not be rendered"), | |||
| (PERSONAL_MESSAGE, "Alert group message with action buttons and incident log"), | |||
| (PERSONAL_MESSAGE, "Alert group message with action buttons and alert group log"), | |||
There was a problem hiding this comment.
This line here generates a migration, but I think it won't really change anything at the DB level.
| @@ -111,6 +111,19 @@ def send_link_to_channel_message_or_fallback_to_full_incident( | |||
| ) | |||
|
|
|||
|
|
|||
| @shared_dedicated_queue_retry_task(bind=True, autoretry_for=(Exception,), retry_backoff=True, max_retries=None) | |||
| def send_link_to_channel_message_or_fallback_to_full_incident( | |||
There was a problem hiding this comment.
Can't just delete this straight away since it can cause celery issues. So introducing a new task with the same internals but a new name and "deprecating" this one.
iskhakov
approved these changes
Jan 3, 2023
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Makes Telegram integration consistent with the rest of the system so it uses the word "alert group" instead of "incident" when referring to alert groups.
Checklist
CHANGELOG.mdupdated