Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make emails case-insensitive for ICal schedules #1297

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Make emails case-insensitive for ICal schedules #1297

merged 3 commits into from
Feb 6, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Feb 6, 2023 •
edited
Loading

What this PR does

Fixes a bug when current on-call users for web UI and Slack user group are incorrect.

This happens when both conditions below are true:

  • Using an ICal schedule
  • Email of a user in Grafana has a different case than an event in ICal (e.g. User@gmail.com in Grafana, user@gmail.com in ICal event)

The bug was introduced by #1169

Which issue(s) this PR fixes

#1296

Checklist

  • Tests updated
  • CHANGELOG.md updated

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Feb 6, 2023
@vstpme vstpme requested a review from a team February 6, 2023 11:49
@vstpme vstpme merged commit d40db5a into dev Feb 6, 2023
@vstpme vstpme deleted the vadimkerr/schedule-email-case-sensitivity branch February 6, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @matiasb