Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API: allow null escalation chain when creating routes #1557

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Mar 15, 2023

What this PR does

Allows passing null as a value for escalation_chain when creating routes via the public API.

Which issue(s) this PR fixes

This is needed to unblock #1555 + creating a route without an escalation chain is possible in the web UI, so this PR makes the public API more consistent with the web UI.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 15, 2023
@vstpme vstpme removed the pr:no public docs Added to a PR that does not require public documentation updates label Mar 15, 2023
@vstpme vstpme changed the title Allow null escalation chain when creating routes via public API Public API: allow null escalation chain when creating routes Mar 15, 2023
@vstpme vstpme marked this pull request as ready for review March 15, 2023 21:29
@vstpme vstpme requested a review from a team March 15, 2023 21:29
@vstpme vstpme enabled auto-merge March 16, 2023 09:28
@vstpme vstpme added this pull request to the merge queue Mar 16, 2023
Merged via the queue into dev with commit bd12d38 Mar 16, 2023
@vstpme vstpme deleted the vadimkerr/public-api-route-escalation-chain-null branch March 16, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants