-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedules 2nd iteration updates #1720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please, do not merge part with rotation title untill #1833 will be merged. |
# Conflicts: # engine/apps/api/views/alert_group.py
…rafana/oncall into maxim/1502-visualize-schedule-weekends
…rafana/oncall into maxim/1502-visualize-schedule-weekends
On shift update, rotation start will be set to current time, prefer shift start instead when calculating the day/week start mapping.
…rafana/oncall into maxim/1502-visualize-schedule-weekends
maskin25
added
the
pr:no public docs
Added to a PR that does not require public documentation updates
label
Jun 20, 2023
matiasb
approved these changes
Jun 20, 2023
CHANGELOG.md
Outdated
### Added | ||
|
||
- iCal export final schedule oncall [#1501](https://github.com/grafana/oncall/issues/1501) | ||
- Schedules: Allow web-edited overrides for Terraform-managed rotations [828](https://github.com/grafana/oncall/issues/828) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, these 2 above were already released and available (so I would remove them from here)
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Features and bugs related to [[Q1 2023] Iteration with Schedules](https://github.com/grafana/oncall-private/issues/1660) milestone ## Which issue(s) this PR fixes ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Innokentii Konstantinov <innokenty.konstantinov@grafana.com> Co-authored-by: Matias Bordese <mbordese@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Features and bugs related to [Q1 2023] Iteration with Schedules milestone
Which issue(s) this PR fixes
Checklist
pr:no public docs
PR label added if not required)CHANGELOG.md
updated (orpr:no changelog
PR label added if not required)