Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in web title and message templates rendering and visual representation #1747

Merged
merged 17 commits into from
May 2, 2023

Conversation

iskhakov
Copy link
Contributor

What this PR does

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@iskhakov iskhakov requested a review from a team April 14, 2023 01:39
@iskhakov iskhakov changed the title Rewrite alertmanager template Rewrite default templates Apr 14, 2023
@iskhakov iskhakov marked this pull request as draft April 14, 2023 01:40
@@ -3,7 +3,7 @@ import dompurify from 'dompurify';
export default function sanitize(str: string): string {
return dompurify.sanitize(str, {
USE_PROFILES: { html: true },
FORBID_TAGS: ['form', 'input', 'pre'],
FORBID_TAGS: ['form', 'input'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maskin25 can you approve this change?

@iskhakov iskhakov marked this pull request as ready for review May 2, 2023 06:11
@iskhakov iskhakov requested a review from a team May 2, 2023 06:11
@iskhakov iskhakov added the pr:no public docs Added to a PR that does not require public documentation updates label May 2, 2023
@iskhakov iskhakov changed the title Rewrite default templates Fix bugs in web title and message templates rendering and visual representation May 2, 2023
@iskhakov iskhakov enabled auto-merge May 2, 2023 06:15
@iskhakov iskhakov disabled auto-merge May 2, 2023 08:57
@iskhakov iskhakov merged commit 14b6926 into dev May 2, 2023
@iskhakov iskhakov deleted the iskhakov/refactor-templates branch May 2, 2023 08:57
brojd pushed a commit that referenced this pull request Sep 18, 2024
…esentation (#1747)

# What this PR does

## Which issue(s) this PR fixes

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants