Add is_default fields to templates, remove WritableSerialiserMethodFi… #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld, refactor fields
iskhakov
changed the title
|
I have a feeling that to_internal_value override could be removed completely, but it requires some deep dive in drf. Please, consider change a comment on line 238: "Override method to handle update of templates, not as a declared drf fields. Could be improved without overriding whole method." |
Konstantinov-Innokentii
approved these changes
Apr 18, 2023
iskhakov
added
the
pr:no public docs
iskhakov
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eld, refactor fields
<template>_is_defaultboolean field toapi/internal/v1/alert_receive_channel_templates/***/endpointWhat this PR does
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)