Remove template editor from Slack #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konstantinov-Innokentii
approved these changes
Apr 28, 2023
| if default_value: | ||
| block["element"]["initial_value"] = default_value | ||
| blocks.append(block) | ||
| {"type": "section", "text": {"type": "mrkdwn", "text": "Once changed Refresh the alert group"}}, |
There was a problem hiding this comment.
Do we really need refresh alert group? We don't have this for msteams and telegram
There was a problem hiding this comment.
We don't want to silently remove the button, so keeping this for transition period and then decide
iskhakov
added
the
pr:no public docs
vstpme
approved these changes
Apr 28, 2023
| "type": "section", | ||
| "text": { | ||
| "type": "mrkdwn", | ||
| "text": f":point_right: Click <{alert_receive_channel.web_link}|here> to open Integrations settings, edit Slack templates and return here", |
There was a problem hiding this comment.
nit: Maybe use a button with a URL as shown in Slack docs to redirect to the web UI? A button with URL seems to be more appropriate for this use case
There was a problem hiding this comment.
In the next version we’ll have 3 urls to 3 templates
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)