Do not hide not secret settings in the web plugin UI

[alexintech]

What this PR does

In the web plugin UI Settings -> Env Variables if variable is not secret, do not hide its value.

Which issue(s) this PR fixes

Checklist

• Unit, integration, and e2e (if applicable) tests updated
• Documentation added (or pr:no public docs PR label added if not required)
• CHANGELOG.md updated (or pr:no changelog PR label added if not required)

[Konstantinov-Innokentii]

@vadimkerr what do you think?

[vstpme]

I personally like all values hidden by default so it's safe to open this page when screen sharing / making screenshots. Hiding all values by default also makes things simpler IMO, so there's only two options – either all settings are hidden or all settings are exposed.
wdyt @grafana/grafana-oncall-frontend @Matvey-Kuk?

[Konstantinov-Innokentii]

@vadimkerr I don't like, that all values are hidden. With ability to change phone provider or ESP for inbound email it feels strange to hide chosen options.

[alexintech]

When I want to change the value of a setting, I scroll down for some non-secret setting. But when I press the "Edit" button, the input is cleared, so you can't see the current value, because of this <Text> behavior.

oncall/grafana-plugin/src/components/Text/Text.tsx

Line 62 in bd14292

setValue(clearBeforeEdit || hidden ? '' : (children as string));

I close the modal window, scroll up, click the "Show values" button, scroll down again, and only then can I edit the value. After refreshing the page, all the values are hidden again. That's a little cumbersome.

[joeyorlando]

Overall LGTM. Consider adding a jest snapshot test for the two cases where a value is hidden, and when it is not hidden.

[joeyorlando]

nit can the hideValues && item.is_secret logic be deduplicated into a function on the LiveSettings class?

[alexintech]

I don't suppose that it's necessary.

[alexintech]

Overall LGTM. Consider adding a jest snapshot test for the two cases where a value is hidden, and when it is not hidden.

I've tried to write a test, but I have not much experience in frontend. All my attempts failed.