Fix inbound email bug when attaching files #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstpme
changed the title
vstpme
added
the
pr:no public docs
vstpme
changed the title
vstpme
commented
May 18, 2023
| @@ -69,7 +69,7 @@ def post(self, request, alert_receive_channel): | |||
| alert_receive_channel_pk=alert_receive_channel.pk, | |||
| image_url=None, | |||
| link_to_upstream_details=None, | |||
| integration_unique_data=request.data, | |||
| integration_unique_data=None, | |||
There was a problem hiding this comment.
This data is not needed, the only fields available for templating are subject, message, and sender.
matiasb
approved these changes
May 18, 2023
matiasb
pushed a commit
that referenced
this pull request
May 18, 2023
# What this PR does Fix inbound email endpoint bug when attaching files to email leads to HTTP 500. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fix inbound email endpoint bug when attaching files to email leads to HTTP 500.
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)