Fix bugs in helm chart with external postgresql configuration #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
approved these changes
May 26, 2023
There was a problem hiding this comment.
hi there @alexintech 👋
Thanks a lot for this contribution. Big kudos for adding the unit tests as well 🔥 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixing some bugs with external Postgresql configuration.
Also I added some unit tests for helm chart using helm-unittest. If it's not an appropriate tool, please suggest another, or I can remove that test. I added this Github Action to run helm unit tests.
Which issue(s) this PR fixes
closes #1727
closes #1923
closes #1245
closes #845
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)