Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouping templating polishing11 #2293

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Grouping templating polishing11 #2293

merged 2 commits into from
Jun 20, 2023

Conversation

Ukochka
Copy link
Contributor

@Ukochka Ukochka commented Jun 20, 2023

  • Alert group scroll
  • Result scroll right padding
  • Cheatsheet scroll right padding
  • Template editor and cheatsheet title alight center
  • Edit custom payload - left padding
  • Change background of Use custom payload title like Template Editor
  • No alert groups is missing right border
  • Save template - should not close the drawer if there is an error
  • Width cheatsheet code 100%
  • Edit/close Alert payload margin 8px
  • Background secondary Result - when Select alert group message

@Ukochka Ukochka added pr:no changelog pr:no public docs Added to a PR that does not require public documentation updates labels Jun 20, 2023
@Ukochka Ukochka requested a review from a team June 20, 2023 12:57
teodosii
teodosii reviewed Jun 20, 2023
View reviewed changes
grafana-plugin/src/components/CheatSheet/CheatSheet.tsx
@@ -30,7 +30,7 @@ const CheatSheet = (props: CheatSheetProps) => {
<IconButton name="times" onClick={onClose} />
</HorizontalGroup>
<Text type="secondary">{cheatSheetData.description}</Text>
<div>
<div style={{ width: '100%' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use class u-width-100 instead (cx('u-width-100'))

@Ukochka Ukochka added this pull request to the merge queue Jun 20, 2023
Merged via the queue into dev with commit e4788d5 Jun 20, 2023
@Ukochka Ukochka deleted the grouping-templating-polishing11 branch June 20, 2023 15:16
brojd pushed a commit that referenced this pull request Sep 18, 2024
@Ukochka
Grouping templating polishing11 (#2293)
8efdaef 
- [x] Alert group scroll
- [x] Result scroll right padding
- [x] Cheatsheet scroll right padding
- [x] Template editor and cheatsheet title alight center
- [x] Edit custom payload - left padding
- [x] Change background of Use custom payload title like Template Editor
- [x] No alert groups is missing right border
- [x] Save template - should not close the drawer if there is an error
- [x] Width cheatsheet code 100%
- [x] Edit/close Alert payload margin 8px
- [x] Background secondary Result - when Select alert group message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodosii teodosii teodosii approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ukochka @teodosii