Remove url from sms notification, change format #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
users can include URL's in the original data or via templates, right? |
|
➕ for @Dieterbe's comment, I had the same question. |
|
Only the title for SMS is editable, but if a URL gets put as the title it could still be blocked. A warning in the template editor would be good and we should completely strip out URLs in the phone provider. One annoying thing I noticed on my phone is that even without protocol it converts to a link if it has a TLD. |
|
Thank you for the suggestions! |
joeyorlando
reviewed
Jun 27, 2023
grafana-plugin/src/components/AlertTemplates/CommonAlertTemplatesForm.config.ts
Outdated
Show resolved
Hide resolved
…tesForm.config.ts Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
iskhakov
added
the
pr:no public docs
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Remove link from sms notification to avoid difficulties with different countries anti-spam regulations ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Remove link from sms notification to avoid difficulties with different countries anti-spam regulations
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)