address mobile device push notification delivery issue when user had > 1 registered device #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
the
pr:no public docs
iskhakov
reviewed
Jul 4, 2023
iskhakov
approved these changes
Jul 5, 2023
|
great job, approved |
joeyorlando
force-pushed
the
jorlando/delete-inactive-registered-mobile-devices
branch
from
4f3aa5a to
d7a6f45
Compare
joeyorlando
deleted the
jorlando/delete-inactive-registered-mobile-devices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Address issue where if the user had multiple registered devices w/ FCM, doing django queries like
.first()could potentially pick the wrong device. Do this in two ways:set the
DELETE_INACTIVE_DEVICESfcm_djangosetting toTrue. According to the docs, this works as follows:Customizing the
FCMDevicemodel provided byfcm_django. Add a new method,get_active_device_for_user, so that we can centralize the logic for this rather than duplicatingFCMDevice.objects.filter(user=user).first()Which issue(s) this PR fixes
https://raintank-corp.slack.com/archives/C0229FD3CE9/p1688461915752119
Checklist
pr:no public docsPR label added if not required) (N/A)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)