remove deprecated heartbeat_heartbeat table/model #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
the
pr:no public docs
joeyorlando
changed the title
joeyorlando
commented
Jul 14, 2023
Comment on lines
-100
to
-154
| class HeartBeat(BaseHeartBeat): | ||
| """ | ||
| HeartBeat Integration itself | ||
| """ | ||
|
|
||
| alert_receive_channel = models.ForeignKey( | ||
| "alerts.AlertReceiveChannel", on_delete=models.CASCADE, related_name="heartbeats" | ||
| ) | ||
|
|
||
| message = models.TextField(default="") | ||
| title = models.TextField(default="HeartBeat Title") | ||
| link = models.URLField(max_length=500, default=None, null=True) | ||
| user_defined_id = models.CharField(default="default", max_length=100) | ||
|
|
||
| def on_heartbeat_restored(self): | ||
| create_alert.apply_async( | ||
| kwargs={ | ||
| "title": "[OK] " + self.title, | ||
| "message": self.title, | ||
| "image_url": None, | ||
| "link_to_upstream_details": self.link, | ||
| "alert_receive_channel_pk": self.alert_receive_channel.pk, | ||
| "integration_unique_data": {}, | ||
| "raw_request_data": { | ||
| "is_resolve": True, | ||
| "id": self.pk, | ||
| "user_defined_id": self.user_defined_id, | ||
| }, | ||
| }, | ||
| ) | ||
|
|
||
| def on_heartbeat_expired(self): | ||
| create_alert.apply_async( | ||
| kwargs={ | ||
| "title": "[EXPIRED] " + self.title, | ||
| "message": self.message | ||
| + "\nCreated: {}\nExpires: {}\nLast HeartBeat: {}".format( | ||
| self.created_at, | ||
| self.expiration_time, | ||
| self.last_checkup_task_time, | ||
| ), | ||
| "image_url": None, | ||
| "link_to_upstream_details": self.link, | ||
| "alert_receive_channel_pk": self.alert_receive_channel.pk, | ||
| "integration_unique_data": {}, | ||
| "raw_request_data": { | ||
| "is_resolve": False, | ||
| "id": self.pk, | ||
| "user_defined_id": self.user_defined_id, | ||
| }, | ||
| } | ||
| ) | ||
|
|
||
| class Meta: | ||
| unique_together = (("alert_receive_channel", "user_defined_id"),) |
There was a problem hiding this comment.
this model does not appear to be used anywhere. It's table has zero data in it in our production/staging databases. Lets remove it.
engine/apps/heartbeat/tasks.py
Outdated
There was a problem hiding this comment.
the two deleted tasks here iterate over heartbeat.HeartBeat objects, and since there is no data to iterate over, we can remove
| @@ -33,7 +32,6 @@ | |||
| path("grafana_alerting/<str:alert_channel_key>/", GrafanaAlertingAPIView.as_view(), name="grafana_alerting"), | |||
| path("alertmanager/<str:alert_channel_key>/", AlertManagerAPIView.as_view(), name="alertmanager"), | |||
| path("amazon_sns/<str:alert_channel_key>/", AmazonSNS.as_view(), name="amazon_sns"), | |||
| path("heartbeat/<str:alert_channel_key>/", HeartBeatAPIView.as_view(), name="heartbeat"), | |||
There was a problem hiding this comment.
there doesn't appear to be any traffic to this endpoint, fairly certain it is safe to remove, alongside the model/table. All new heartbeats appear to be of the IntegrationHeartBeat type
| @@ -262,122 +257,6 @@ def post(self, request, *args, **kwargs): | |||
| return Response("Ok.") | |||
|
|
|||
|
|
|||
| # TODO: restore HeartBeatAPIView integration or clean it up as it is not used now | |||
joeyorlando
changed the title
joeyorlando
force-pushed
the
jorlando/fix-heartbeat-icon-on-integration-page
branch
from
55b3f21 to
fd9c80e
Compare
joeyorlando
force-pushed
the
jorlando/fix-heartbeat-icon-on-integration-page
branch
from
710b7b5 to
7969606
Compare
joeyorlando
commented
Jul 15, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does - Remove `heartbeat_heartbeat` table. This model/table does not seems to be deprecated/used anywhere (no data in this in production/staging; see more comments in the code about this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
heartbeat_heartbeattable. This model/table does not seems to be deprecated/used anywhere (no data in this in production/staging; see more comments in the code about this).