add option for sidecar containers in helm chart #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu1as
force-pushed
the
add-extra-containers-to-helm-chart
branch
2 times, most recently
from
c782157 to
6b5ccd9
Compare
|
|
|
thank you for the contribution! Would you please add some helm unit tests |
lu1as
force-pushed
the
add-extra-containers-to-helm-chart
branch
from
6b5ccd9 to
edcedba
Compare
|
@iskhakov I added unit tests and already found an issue 😄 It's fixed now. |
|
I just added the option for |
lu1as
force-pushed
the
add-extra-containers-to-helm-chart
branch
from
c9545d0 to
0e9394c
Compare
joeyorlando
approved these changes
Jul 31, 2023
joeyorlando
added
the
pr:no public docs
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lu1as
force-pushed
the
add-extra-containers-to-helm-chart
branch
from
0e9394c to
bd17795
Compare
lu1as
force-pushed
the
add-extra-containers-to-helm-chart
branch
from
bd17795 to
eddc456
Compare
lu1as
force-pushed
the
add-extra-containers-to-helm-chart
branch
from
eddc456 to
4acf553
Compare
|
I rebased the source branch to resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds support for defining extra containers which run as sidecar alongside the celery and engine containers
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)