Use periodic task for heartbeats #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
approved these changes
Aug 2, 2023
engine/apps/heartbeat/models.py
Outdated
Comment on lines
48
to
51
| # Deprecated. This field is not used. TODO: remove it | ||
| last_checkup_task_time = models.DateTimeField(default=None, null=True) | ||
| # Deprecated. Stored the latest scheduled `integration_heartbeat_checkup` task id. TODO: remove it | ||
| actual_check_up_task_id = models.CharField(max_length=100) |
There was a problem hiding this comment.
would it be safe to simply drop these two fields in this PR? Or at a minimum remove them from the model without dropping them from the db, so that a subsequent PR we can drop them? (Vadim docs have more info on this)
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
joeyorlando
reviewed
Aug 2, 2023
iskhakov
added
the
pr:no public docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)