Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getting/updating contact points for Grafana Alerting integration #2742

Merged
merged 49 commits into from
Aug 18, 2023

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented Aug 3, 2023

This PR improves Grafana Alerting integration:

  • get alerting contact points "on fly" instead of keeping them in db
  • add ability to connect more than one contact point
  • add ability to create new contact point on create Grafana Alerting integration
  • show warnings in integration settings for non-active contact points
  • remove creation alerting notification policies on create Grafana Alerting integration

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

teodosii and others added 30 commits July 28, 2023 16:27
- improve alertmanager datasource filter
- add getting default config for mimir alertmanager if config was deleted
- fix connecting not existing contact point
- add checking if "oncall" contact point type is available
@Ferril Ferril added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 18, 2023
@Ferril Ferril marked this pull request as ready for review August 18, 2023 07:16
@Ferril Ferril requested review from a team August 18, 2023 07:16
@Ferril Ferril changed the title Draft getting/updating contact points for Grafana Alerting integration Improve getting/updating contact points for Grafana Alerting integration Aug 18, 2023
@Ferril Ferril merged commit 58a9a39 into dev Aug 18, 2023
@Ferril Ferril deleted the grafana-alerting-integration-v2 branch August 18, 2023 10:12
brojd pushed a commit that referenced this pull request Sep 18, 2024
…ion (#2742)

This PR improves Grafana Alerting integration:
- get alerting contact points "on fly" instead of keeping them in db
- add ability to connect more than one contact point
- add ability to create new contact point on create Grafana Alerting
integration
- show warnings in integration settings for non-active contact points
- remove creation alerting notification policies on create Grafana
Alerting integration

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)

---------

Co-authored-by: Rares Mardare <rares.mardare@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants