-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve getting/updating contact points for Grafana Alerting integration #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection within GForm
…erting sync manager
…lerting sync manager
- improve alertmanager datasource filter - add getting default config for mimir alertmanager if config was deleted - fix connecting not existing contact point - add checking if "oncall" contact point type is available
…or contact points endpoints
Ferril
added
the
pr:no public docs
Added to a PR that does not require public documentation updates
label
Aug 18, 2023
Ferril
changed the title
Draft getting/updating contact points for Grafana Alerting integration
Improve getting/updating contact points for Grafana Alerting integration
Aug 18, 2023
Konstantinov-Innokentii
approved these changes
Aug 18, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
…ion (#2742) This PR improves Grafana Alerting integration: - get alerting contact points "on fly" instead of keeping them in db - add ability to connect more than one contact point - add ability to create new contact point on create Grafana Alerting integration - show warnings in integration settings for non-active contact points - remove creation alerting notification policies on create Grafana Alerting integration ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Rares Mardare <rares.mardare@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Grafana Alerting integration:
Checklist
pr:no public docs
PR label added if not required)CHANGELOG.md
updated (orpr:no changelog
PR label added if not required)