Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable FEATURE_INBOUND_EMAIL_ENABLED by default #2846

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Enable FEATURE_INBOUND_EMAIL_ENABLED by default #2846

merged 2 commits into from
Aug 21, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Aug 21, 2023 •
edited
Loading

What this PR does

Sets FEATURE_INBOUND_EMAIL_ENABLED to True by default, so inbound email integration setup is consistent with the docs.

Which issue(s) this PR fixes

#2777

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 21, 2023
@vstpme vstpme marked this pull request as ready for review August 21, 2023 14:08
@vstpme vstpme requested a review from a team August 21, 2023 14:08
@vstpme vstpme enabled auto-merge August 21, 2023 14:08
@vstpme vstpme mentioned this pull request Aug 21, 2023
Closed
@vstpme vstpme added this pull request to the merge queue Aug 21, 2023
Merged via the queue into dev with commit 28eb671 Aug 21, 2023
@vstpme vstpme deleted the vadimkerr/enable-inbound-email-oss branch August 21, 2023 14:28
joeyorlando
joeyorlando reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadimkerr since this is enabled by default, is there still value in keeping the feature flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando left review comments

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstpme @matiasb @joeyorlando