Public API: Acknowledge & Resolve actions #3108
Conversation
| operations = [ | ||
| migrations.AddField( | ||
| model_name='alertgrouplogrecord', | ||
| name='action_source', |
There was a problem hiding this comment.
Saving action_source to DB so it's possible to differentiate between actions performed via public API vs. other "action sources"
| if self.action_source == ActionSource.API: | ||
| author_name = "API" |
There was a problem hiding this comment.
Making it so API actions are shown as "... by API" in the alert group timeline
There was a problem hiding this comment.
To be sure, we would still have the API token owner set as user in the record, right?
| @@ -479,7 +487,7 @@ def rendered_log_line_action(self, for_slack=False, html=False, substitute_autho | |||
| f"because it is already attached or resolved." | |||
| ) | |||
| elif self.type == AlertGroupLogRecord.TYPE_RESOLVED: | |||
| result += f"alert group resolved {f'by {author_name}'if author_name else ''}" | |||
| result += f"resolved {f'by {author_name}'if author_name else ''}" | |||
There was a problem hiding this comment.
"alert group resolved by ..." -> just "resolved by ..." (all other actions omit the "alert group" part, so making this a bit more consistent)
| @@ -112,3 +114,74 @@ def destroy(self, request, *args, **kwargs): | |||
| wipe.apply_async((instance.pk, request.user.pk)) | |||
|
|
|||
| return Response(status=status.HTTP_204_NO_CONTENT) | |||
|
|
|||
| @action(methods=["post"], detail=True) | |||
There was a problem hiding this comment.
These API actions mostly duplicate the internal API logic. I think these alert group state changes should be eventually refactored to be a proper FSM that can be reused in both APIs, but I want to leave this outside of the scope of this PR/issue.
| @@ -112,3 +114,74 @@ def destroy(self, request, *args, **kwargs): | |||
| wipe.apply_async((instance.pk, request.user.pk)) | |||
|
|
|||
| return Response(status=status.HTTP_204_NO_CONTENT) | |||
|
|
|||
| @action(methods=["post"], detail=True) | |||
| if self.action_source == ActionSource.API: | ||
| author_name = "API" |
There was a problem hiding this comment.
To be sure, we would still have the API token owner set as user in the record, right?
# Conflicts: # CHANGELOG.md
What this PR does
Makes it possible to acknowledge/unacknowledge and resolve/unresolve alert groups via public API, and makes sure these actions are reflected properly in the alert group timeline.
Demo
curl --request POST \ --header "Authorization: TOKEN" \ http://localhost:8080/api/v1/alert_groups/IQMHLV8INB24N/resolveWhich issue(s) this PR fixes
#3051
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)