Permissions for labels #3173
Merged
Permissions for labels #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferril
added
the
pr:no public docs
joeyorlando
reviewed
Oct 20, 2023
engine/apps/api/permissions.py
Outdated
Comment on lines
284
to
291
| def user_is_authorized_basic_role(user: "User", required_permission: LegacyAccessControlRole) -> bool: | ||
| """ | ||
| This function checks user basic role | ||
|
|
||
| user - The user to check permissions for | ||
| required_permission - A basic role that a user must have to be considered authorized | ||
| """ | ||
| return user.role <= required_permission |
There was a problem hiding this comment.
I would suggest trying to reuse the less-than-or-equal-to auth logic that is defined above in user_is_authorized (or somehow refactoring that function such that we don't need two separate ones like this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds check for basic role permissions on get/create/update labels
Which issue(s) this PR fixes
https://github.com/grafana/oncall-private/issues/2194
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)