Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return alert groups for deleted integrations on private api #3223

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Return alert groups for deleted integrations on private api #3223

merged 3 commits into from
Nov 2, 2023

Conversation

iskhakov
Copy link
Contributor

@iskhakov iskhakov commented Oct 31, 2023 •
edited
Loading

What this PR does

This PR adds alert groups from deleted integrations to the api response. More details in this slack thread

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@iskhakov iskhakov requested a review from a team October 31, 2023 12:38
@Matvey-Kuk Matvey-Kuk added pr:no public docs Added to a PR that does not require public documentation updates pr:no changelog labels Oct 31, 2023
@Matvey-Kuk Matvey-Kuk enabled auto-merge October 31, 2023 12:46
@iskhakov iskhakov disabled auto-merge October 31, 2023 12:48
joeyorlando
joeyorlando approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth adding a test case for this?

@iskhakov iskhakov added this pull request to the merge queue Nov 2, 2023
@iskhakov iskhakov removed this pull request from the merge queue due to a manual request Nov 2, 2023
@iskhakov iskhakov enabled auto-merge November 2, 2023 08:39
@iskhakov iskhakov added this pull request to the merge queue Nov 2, 2023
Merged via the queue into dev with commit a936430 Nov 2, 2023
20 checks passed
@iskhakov iskhakov deleted the iskhakov/show-ag-for-deleted-integrations branch November 2, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskhakov @joeyorlando @Matvey-Kuk