Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedules rotation form tweaks #3365

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Schedules rotation form tweaks #3365

merged 2 commits into from
Nov 16, 2023

Conversation

teodosii
Copy link
Member

What this PR does

  • adds proper boundary constraints on dragging the rotation modal (can't drag outside of parent container anymore)
  • add scrolling within the users list in the rotation modal

Which issue(s) this PR fixes

Fixes https://github.com/grafana/oncall-private/issues/2299

@teodosii teodosii requested a review from a team November 16, 2023 08:02
@teodosii teodosii added the pr:no public docs Added to a PR that does not require public documentation updates label Nov 16, 2023
@teodosii teodosii added this pull request to the merge queue Nov 16, 2023
Merged via the queue into dev with commit 607e87c Nov 16, 2023
18 of 20 checks passed
@teodosii teodosii deleted the rares/schedules-fixes-2 branch November 16, 2023 09:24
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does

- adds proper boundary constraints on dragging the rotation modal (can't
drag outside of parent container anymore)
- add scrolling within the users list in the rotation modal

## Which issue(s) this PR fixes

Fixes grafana/oncall-private#2299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants