Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete direct paging integration on team delete #3367

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Nov 16, 2023

What this PR does

  • Fix a bug when it's not possible to delete duplicate DP integrations for "No team"
  • Make so that when a team is deleted, its DP integration is deleted automatically

Which issue(s) this PR fixes

https://github.com/grafana/oncall-private/issues/2296

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme changed the title Direct paging integration deletion Delete DP integration on team delete Nov 16, 2023
@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Nov 16, 2023
@vstpme vstpme changed the title Delete DP integration on team delete Delete direct paging integration on team delete Nov 16, 2023
@vstpme vstpme marked this pull request as ready for review November 16, 2023 13:07
@vstpme vstpme requested a review from a team November 16, 2023 13:07
@vstpme vstpme added this pull request to the merge queue Nov 16, 2023
@vstpme vstpme removed this pull request from the merge queue due to a manual request Nov 16, 2023
@vstpme vstpme merged commit 93badbd into dev Nov 16, 2023
17 of 19 checks passed
@vstpme vstpme deleted the vadimkerr/direct-paging-duplicate-delete branch November 16, 2023 13:54
Comment on lines +869 to +874
assert (
organization.alert_receive_channels.filter(
integration=AlertReceiveChannel.INTEGRATION_DIRECT_PAGING, team=None
).count()
== 2
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will only be the case until the next sync runs, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants