Retry perform_notification with Telegram ratelimit countdown on RetryAfter error
#3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferril
added
the
pr:no public docs
matiasb
reviewed
Jan 24, 2024
| TelegramToUserConnector.notify_user(user, alert_group, notification_policy) | ||
| except RetryAfter as e: | ||
| countdown = getattr(e, "retry_after", 3) | ||
| perform_notification.retry((log_record_pk,), countdown=countdown, exc=e) |
There was a problem hiding this comment.
FYI, I think retry will raise an exception (besides queuing a new task), and since we have the autoretry_for set for Exception, you will end having 2 new tasks from this (the retry because of the exception, and the task added by the retry call). See here too.
There was a problem hiding this comment.
hm, thanks for the information 👍 I wasn't able to reproduce it locally though, I can see only one retrying task, but it probably makes sense to change the call to apply_async here just in case 🤔
UPD: or use dont_autoretry_for=(Retry,)
iskhakov
approved these changes
Jan 24, 2024
matiasb
approved these changes
Jan 24, 2024
iskhakov
pushed a commit
that referenced
this pull request
Feb 20, 2024
…tryAfter` error (#3744) # What this PR does Use Telegram ratelimit countdown when retry `perform_notification` task on `RetryAfter` error ## Which issue(s) this PR fixes grafana/oncall-private#2451 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Use Telegram ratelimit countdown when retry
perform_notificationtask onRetryAftererrorWhich issue(s) this PR fixes
https://github.com/grafana/oncall-private/issues/2451
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)