expose OUTGOING_WEBHOOK_TIMEOUT as env var #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joeyorlando
requested changes
Jan 31, 2024
There was a problem hiding this comment.
hi there! thanks for your contribution. The concept makes sense, there's just a few changes needed before we can merge this in.
Also, do you mind augmenting the documentation here to mention that this 4 second timeout is configurable?
Thank you! 🙏
joeyorlando
reviewed
Feb 1, 2024
|
@KevinDW-Fluxys do you mind adding this change to the "Added" section in the |
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
joeyorlando
reviewed
Feb 1, 2024
There was a problem hiding this comment.
last two things:
- address the linting issues
- revert changes to
engine/apps/alerts/utils.py
after that I'll go ahead and approve and merge this 😄
joeyorlando
approved these changes
Feb 1, 2024
|
@joeyorlando Missed a linting change. Thanks for the patient reviewing, I'm not so used to doing this, but its been fun :-) |
iskhakov
pushed a commit
that referenced
this pull request
Feb 20, 2024
# What this PR does It adds functionality to be able to configure the outgoing webhook timeout from an environment variable. ## Which issue(s) this PR fixes Running into timeouts when outgoing webhooks take longer than 4 seconds (which is exceptional, but can happen) the webhook reports failure, while it still might have succeeded on the webhook side. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Joey Orlando <joey.orlando@grafana.com> Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
It adds functionality to be able to configure the outgoing webhook timeout from an environment variable.
Which issue(s) this PR fixes
Running into timeouts when outgoing webhooks take longer than 4 seconds (which is exceptional, but can happen) the webhook reports failure, while it still might have succeeded on the webhook side.
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)