Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert requiring permission on Slack direct paging #3881

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Revert requiring permission on Slack direct paging #3881

merged 2 commits into from
Feb 12, 2024

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Feb 12, 2024 •
edited
Loading

Reverting part of #3861

@matiasb matiasb added pr:no changelog pr:no public docs Added to a PR that does not require public documentation updates labels Feb 12, 2024
@matiasb matiasb marked this pull request as ready for review February 12, 2024 18:35
@matiasb matiasb requested a review from a team February 12, 2024 18:35
@matiasb matiasb added this pull request to the merge queue Feb 12, 2024
Merged via the queue into dev with commit 5ecdc26 Feb 12, 2024
21 checks passed
@matiasb matiasb deleted the matiasb/revert-paging-auth-updates branch February 12, 2024 18:59
@matiasb matiasb mentioned this pull request Feb 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 14, 2024
@matiasb
Check for permissions on Slack escalate command (#3891)
adaab1c 
Related to #3109

Fixes issue from #3881 (problem
was that there is no organization set in the Slack request, making it
impossible to check for user permissions; check permission once an
organization is set in the form instead).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstpme vstpme vstpme approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @vstpme