Fixed schedule rotations form #3904
Conversation
teodosii
added
the
pr:no public docs
| @@ -97,3 +96,21 @@ | |||
| margin-bottom: 10px; | |||
| width: 100%; | |||
| } | |||
|
|
|||
| @media (max-height: 768px) { | |||
There was a problem hiding this comment.
Kind of a must because the scrollable container should scale differently based on window height (e. g. 45vh too less for anything higher than 1024px)
| @@ -421,6 +422,13 @@ export const RotationForm = observer((props: RotationFormProps) => { | |||
| } | |||
| }, [store.timezoneStore.selectedTimezoneOffset]); | |||
|
|
|||
| useEffect(() => { | |||
| window.addEventListener('resize', onResize); | |||
There was a problem hiding this comment.
hide modal on resize so that it's not accidentally moved into edges where it's not visible (react-draggable bounds only work on dragging, not generic placement)
| @@ -699,18 +707,38 @@ export const RotationForm = observer((props: RotationFormProps) => { | |||
| </> | |||
| ); | |||
|
|
|||
| function onResize() { | |||
| onHide(); | |||
There was a problem hiding this comment.
why not call onHide directly without creating proxy fn as it does only one thing?
There was a problem hiding this comment.
Hmm, the passed prop could change reference and you no longer remove the correct associated handler, that was my thinking back then
There was a problem hiding this comment.
Ok, we can leave like that, I missed it's passed as a prop 👍
# What this PR does - Improves the calculation of dragging area limits - Fixes some minor margin/padding inconsistencies for which horizontal scrollbar was appended ## Which issue(s) this PR fixes #3868 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
What this PR does
Which issue(s) this PR fixes
#3868
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)