Helm: allow for using existing secret for RabbitMQ #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
|
/cc @iskhakov since you also merged my last helm related PR. |
iskhakov
approved these changes
Nov 3, 2022
3 tasks
|
@davidspek just FYI, I've applied a small fix to the RABBITMQ_USERNAME part |
GRomR1
added a commit
to GRomR1/oncall
that referenced
this pull request
Nov 18, 2022
This was referenced Nov 18, 2022
3 tasks
iskhakov
added a commit
that referenced
this pull request
Jun 13, 2023
# What this PR does This PR adds the ability to use an existing secret for external Redis and external MySQL and it follows the same changes that PR #761 did for RabbitMQ (including the fix that was done for it later in #775) ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
iskhakov
added a commit
that referenced
this pull request
Jun 16, 2023
**What this PR does**: The existing value brokes the release when using external RabbitMQ. ``` Warning Failed 6s (x11 over 112s) kubelet Error: couldn't find key password in Secret monitoring/oncall-rabbitmq-external ``` **Which issue(s) this PR fixes**: Related MR [#761](#761) **Checklist** - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated --------- Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
Ukochka
pushed a commit
that referenced
this pull request
Jun 16, 2023
**What this PR does**: The existing value brokes the release when using external RabbitMQ. ``` Warning Failed 6s (x11 over 112s) kubelet Error: couldn't find key password in Secret monitoring/oncall-rabbitmq-external ``` **Which issue(s) this PR fixes**: Related MR [#761](#761) **Checklist** - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated --------- Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds the ability to use an existing secret for external RabbitMQ. It a key in the existing secret can be specified for both the password and the username. The ability to specify the username key is required when an operator is used to create RabbitMQ credentials. We are using the RabbitMQ Messaging Topology Kubernetes Operator to create the vhost, user and permissions for OnCall, where both the username and password are auto-generated and placed into a secret.
Checklist
CHANGELOG.mdupdated