Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Time series legend is duplicating #178

Closed
fridgepoet opened this issue May 22, 2023 · 0 comments · Fixed by #180
Closed

Backend: Time series legend is duplicating #178

fridgepoet opened this issue May 22, 2023 · 0 comments · Fixed by #180
Assignees
@fridgepoet
Labels
datasource/OpenSearch effort/small type/bug Something isn't working

Comments

@fridgepoet
Copy link
Member

fridgepoet commented May 22, 2023 •
edited
Loading

What happened:
While working on this PR #168, noticed this the legend had duplicated labels:
Screenshot 2023-05-12 at 16 42 45

What you expected to happen:
The legend should only the label once

How to reproduce it (as minimally and precisely as possible):

  • Set OpenSearch datasource
  • Set Average metric on field / Date Histogram on A
  • Add metric "derivative" on Average metric
  • Add Expression $A
  • Observe the duplicated labels

Anything else we need to know?:
Thank you @idastambuk for the pointer on how to resolve the issue
Resolution will be similar to grafana/grafana#66039
Will also use the changes from grafana/grafana#60169

Environment:

  • Grafana version:
  • Plugin version:
@fridgepoet fridgepoet added type/bug Something isn't working datasource/OpenSearch labels May 22, 2023
@fridgepoet fridgepoet mentioned this issue May 22, 2023
Merged
@fridgepoet fridgepoet changed the title Time series legend is duplicating Backend flow: Time series legend is duplicating May 22, 2023
@fridgepoet fridgepoet moved this from Incoming to Backlog in AWS Datasources May 22, 2023
@fridgepoet fridgepoet changed the title Backend flow: Time series legend is duplicating Backend: Time series legend is duplicating May 22, 2023
@fridgepoet fridgepoet mentioned this issue May 22, 2023
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in AWS Datasources May 25, 2023
@fridgepoet fridgepoet self-assigned this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fridgepoet fridgepoet

Labels
datasource/OpenSearch effort/small type/bug Something isn't working
Projects
AWS Datasources
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Backend: Set field.Config.DisplayNameFromDS instead of frame.name grafana/opensearch-datasource
1 participant
@fridgepoet