Backend: Set field.Config.DisplayNameFromDS instead of frame.name #180
Conversation
fridgepoet
requested review from
sarahzinger and
kevinwcyu
and removed request for
a team
|
Backend code coverage report for PR #180
|
|
Frontend code coverage report for PR #180 |
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.5.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.5.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.5.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.5.2... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
| bucket := utils.NewJsonFromAny(v) | ||
| value := castToNullFloat(bucket.Get("doc_count")) |
There was a problem hiding this comment.
is there any diff between castToNullFloat and castToFloat?
There was a problem hiding this comment.
The originally-used castToNullFloat function below uses an underlying standard library type sql.NullFloat64 which is also a way to distinguish between something "null/nil" or with a float64 value. In this case, we can also just use a *float64 type to distinguish between "nil" and float64 and there is no strong reason to use an imported type for that.
Here's a similar discussion: https://stackoverflow.com/questions/33458439/using-sql-nullfloat64-vs-float64-in-golang
In Elasticsearch I noticed they moved towards *float64 so I copied that; I think that in further refactors the castToNullFloat will no longer be used.
What this PR does / why we need it:
The time series legend when displayed from a backend query (alerting, expressions) was duplicating.
This PR applies a change from Elasticsearch to generate field names for the value field of time series frames.
It applies the fixes from another PR in Elasticsearch to move from putting the frame name in
frame.nametofield.Config.DisplayNameFromDSand getting the metric name frommetric.Fieldinstead ofmetric.ID.The screenshot illustrates the same label for a backend flow and frontend flow.
Thank you @idastambuk for pointing out where to set the legend.
Which issue(s) this PR fixes:
Fixes #178