-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backend dependencies #148
Conversation
Backend code coverage report for PR #148
|
Frontend code coverage report for PR #148 |
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7... 🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7... 🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7... 🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
Manually tested and it seemed to work for me! Although I'm seeing a build error in the ci about the ioutil package being deprecated. Why would it build for me with mage and not in CI? Maybe I'm on a wrong version of go or something? |
hey @sarahzinger thanks for having a look. I believe this is not strictly required for https://github.com/grafana/oss-plugin-partnerships/issues/170 so no rush or anything The binary will be built (mage or go build I guess) without emitting this error. The tests will also pass. What we're seeing is a linter error (package is deprecated) and if you're like me you don't run the linter locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Contributes to https://github.com/grafana/oss-plugin-partnerships/issues/170