Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend dependencies #148

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Update backend dependencies #148

merged 2 commits into from
Apr 20, 2023

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet requested a review from a team as a code owner April 19, 2023 14:49
@fridgepoet fridgepoet requested review from iwysiu and sarahzinger and removed request for a team April 19, 2023 14:49
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Backend code coverage report for PR #148

Plugin Main PR Difference
opensearch 43.4% 43.4% 0%

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #148
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@sarahzinger
Copy link
Member

Manually tested and it seemed to work for me! Although I'm seeing a build error in the ci about the ioutil package being deprecated. Why would it build for me with mage and not in CI? Maybe I'm on a wrong version of go or something?

@fridgepoet
Copy link
Member Author

fridgepoet commented Apr 19, 2023

hey @sarahzinger thanks for having a look. I believe this is not strictly required for https://github.com/grafana/oss-plugin-partnerships/issues/170 so no rush or anything

The binary will be built (mage or go build I guess) without emitting this error. The tests will also pass. What we're seeing is a linter error (package is deprecated) and if you're like me you don't run the linter locally.
I'll make a change for this and push it up later!

Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fridgepoet fridgepoet merged commit b2f48ba into main Apr 20, 2023
@fridgepoet fridgepoet deleted the backend-dep branch April 20, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants