Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to opensearchDetectVersion flag #171

Merged
merged 2 commits into from
May 17, 2023
Merged

Remove references to opensearchDetectVersion flag #171

merged 2 commits into from
May 17, 2023

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented May 15, 2023

What this PR does / why we need it:
Removes the references to the feature flags and adjusts the tests to work with the new defaults

Which issue(s) this PR fixes:

Fixes #170

Special notes for your reviewer:

@iwysiu iwysiu requested a review from a team as a code owner May 15, 2023 18:54
@iwysiu iwysiu requested review from fridgepoet and idastambuk and removed request for a team May 15, 2023 18:54
@github-actions
Copy link
Contributor

Backend code coverage report for PR #171
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #171

Plugin Main PR Difference
src 77.85% 77.78% -.07%

@github-actions
Copy link
Contributor

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.5.2...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.5.2...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.5.2...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.5.2...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

1 similar comment
@github-actions
Copy link
Contributor

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.5.2...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.5.2...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.5.2...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.5.2...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@iwysiu iwysiu merged commit 4ca1017 into main May 17, 2023
@iwysiu iwysiu deleted the iwysiu/170 branch May 17, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove feature flag code for Detecting Version
3 participants