-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raw_document query support to backend #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgepoet
changed the title
wip raw_doc query
Add raw_document query support to backend
Jul 13, 2023
This reverts commit 70d4fdc. Planning this for a separate PR
fridgepoet
requested review from
iwysiu,
kevinwcyu and
idastambuk
and removed request for
a team
July 14, 2023 15:07
iwysiu
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just style nits again, with one question about the hit fields
iwysiu
approved these changes
Jul 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This recreates the raw_document query processing that exists in the frontend in the backend. It redirects any queries with only raw_document to the backend. It's very similar to the recent raw_data work.
The query building is based on its equivalent in Elasticsearch and the original PR is here.
The result processing is based on its equivalent in Elasticsearch. The original PR is here.
Which issue(s) this PR fixes:
Fixes #195
Special notes for your reviewer:
As mentioned in the Elasticsearch PR, the order of the keys in the JSON will not be the same between the previous frontend implementation and this backend PR.
Another difference is that the
timestamp
will be an array, not just the value, same as in the Elasticsearch PR.Although we can match the same behavior as the frontend by supplying only the single value from the array, if this more direct result has been acceptable for Elasticsearch users, the code will be simpler.