Lucene metrics: Remove "size":500 from backend processTimeSeriesQuery #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrectly introduced https://github.com/grafana/opensearch-datasource/pull/203/files#diff-44afe4fa7a308b985c56a75c710979bd17870768f6365e65baa40115849846e6R79-R80 Size is 0 in this datasource's frontend code flow query Size is also 0 in Elasticsearch datasource's query
fridgepoet
changed the title
fridgepoet
requested review from
sarahzinger and
kevinwcyu
and removed request for
a team
3 tasks
kevinwcyu
approved these changes
Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Query building (to OpenSearch) was compared between the backend and the frontend for the following query:
One of the differences observed was:
"size":500in the backend query and"size":0in the frontend query. This PR sets the"size":0in the backend query.The
"size":500was incorrectly introduced in https://github.com/grafana/opensearch-datasource/pull/203/files#diff-44afe4fa7a308b985c56a75c710979bd17870768f6365e65baa40115849846e6R79-R80(Another argument in support of
"size":0is that in the Elasticsearch datasource,"size":0for the same type of query.)Which issue(s) this PR fixes:
Contributes to #197
Special notes for your reviewer:
You can include the changes or cherry-pick this commit to enable backend flow everywhere. 021e747
No difference was observed between this change and the squad's non-regression dashboard https://clouddatasources.grafana.net/goto/2I2f2hWIR?orgId=1