Clean unused code from null, refactor parse method #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgepoet
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
fridgepoet
changed the title
idastambuk
approved these changes
Oct 4, 2023
fridgepoet
added a commit
that referenced
this pull request
Oct 4, 2023
* Remove receiver on parse method, just like Elasticsearch * Remove unused code from null package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is a refactor in the backend and should have no impact on the behavior of the data source.
nullpackageparsemethod: this makes the code more similar to Elasticsearch, easier to read over while comparing the two code bases.Special notes for your reviewer:
This was done while working on #197 and tested locally with no noticeable visual difference.