Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend refactor and clean #283

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Backend refactor and clean #283

merged 1 commit into from
Oct 16, 2023

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet commented Oct 12, 2023

What this PR does / why we need it:

  • Return error earlier in processQuery
  • Replace variable function declarations with just functions: we are not currently replacing these functions and it may be best if we avoided that in the future
  • Export aggContainer: used in a different package for testing this upcoming PR. I hate to do a change for a test but maybe it is a hint that things are not organized quite right. Or maybe I have not written the test in the right place. I'd like to keep the upcoming PR focused on the feature changes and this kind of change creates unnecessary noise in it. Let me know if we'd prefer it elsewhere!
  • Clean unused index in searchRequestBuilder

Which issue(s) this PR fixes:

Preparation while working on #280

Special notes for your reviewer:
This was and can be tested locally with our team's plugin provisioning set up and with the Lucene queries going through the backend: cherry-pick the commit from this branch main...backend-flow

Return error earlier in processQuery
Replace variable function declarations with just functions
Export aggContainer (used in a different package for testing in next PR)
Clean unused index in searchRequestBuilder
@fridgepoet fridgepoet marked this pull request as ready for review October 12, 2023 16:53
@fridgepoet fridgepoet requested a review from a team as a code owner October 12, 2023 16:53
@fridgepoet fridgepoet requested review from idastambuk and kevinwcyu and removed request for a team October 12, 2023 16:53
@fridgepoet fridgepoet merged commit 7eef9c8 into main Oct 16, 2023
4 checks passed
@fridgepoet fridgepoet deleted the refactor branch October 16, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants