Migrate to create-plugin and support node 18 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
force-pushed
the
kevinwcyu/node-18
branch
from
56bcdc1
to
8a54d6e
Compare
kevinwcyu
force-pushed
the
kevinwcyu/node-18
branch
from
8a54d6e
to
4721603
Compare
kevinwcyu
requested review from
iwysiu and
sarahzinger
and removed request for
a team
sarahzinger
approved these changes
Oct 18, 2023
| @@ -0,0 +1,25 @@ | |||
| // Due to the grafana/ui Icon component making fetch requests to | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rm -rf node_modules && yarn && yarn lint && yarn test:ci && yarn buildthen tested it with a simple queryNotes to reviewers:
I suggest checking the
Hide whitespacecheckbox in the diff view settings for this.Why does this include migrating from
@grafana/toolkitto@grafana/create-plugin? When updating to Node 18, we run into an error due to an incompatible version of node when runningyarn installdue to dependencies used in@grafana/toolkit, which is now deprecated.What are the notable changes
npx @grafana/create-plugin@latest migrate./config/*all generated files with default configuration for tooling such as webpack, eslint, jest, etc. The following root level files were also modified automatically to use the configuration defined in the/.configdir.eslintrc.prettierrc.jsjest-setup.jsjest.config.jstsconfig.jsonpackage.jsonmodified to include required dev deps and updates the scriptsdocker-compose.yamlused byyarn server.github/workflows/detect-breaking-changes.ymlsets it to use the .nvmrc file to determine the version of node to use instead of hardcoding it.nvmrcis used to determine which version of Node is used to build the app in Drone.CONTRIBUTING.MDremoves theyarn watchcommand which is no longer available, it is now justyarn devsrc/**/*.{ts,tsx}files: formatting changes (prettier), and typescript fixes