Add node graph toggle #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
idastambuk
approved these changes
Mar 19, 2024
|
I like the solution with the temporary toggle! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a node graph toggle to the query editor, doesn't do much yet except send over the boolean to the backend.
Which issue(s) this PR fixes:
Fixes #334
Special notes for your reviewer:
I've done this behind a feature toggle, but did not put the feature toggle into main grafana. We could add it to main grafana if we wanted to but I am not sure it's worth it in this case, it just gives us better typing and things like that. I think it might be enough to just sort of ad-hoc add it as I've done here so that we're able to work on this in multiple prs and merge/release before the full feature is done.