Fix flaky tests #369
Merged
Fix flaky tests #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
changed the title
iwysiu
changed the title
iwysiu
commented
May 1, 2024
| body string | ||
| } | ||
|
|
||
| func createDataQueriesForTests(tsdbQueries []tsdbQuery) []backend.DataQuery { |
There was a problem hiding this comment.
Alternatively I could create a second helper that takes an array, but the map sort of implies that it should take multiple queries.
iwysiu
commented
May 1, 2024
| "name": "HTTP GET /dispatch", | ||
| "startTime": "2023-10-18T07:58:37.818589Z", | ||
| "links": [], | ||
| } |
There was a problem hiding this comment.
I just changed the indents on this to be easier to read.
iwysiu
requested review from
sarahzinger and
kevinwcyu
and removed request for
a team
sarahzinger
reviewed
May 2, 2024
pkg/opensearch/lucene_handler.go
Outdated
| operations := make([]string, 0, len(operationMap)) | ||
| for op := range operationMap { | ||
| operations = append(operations, op) | ||
| } | ||
| slices.Sort(operations) |
There was a problem hiding this comment.
I feel like if sorting the operations benefitted users in someway it might make sense to do this, but if I understand correctly this is always going to be rendered as a graph where sorting won't really matter. I would vote we try sorting in the test if that's possible?
kevinwcyu
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due to backend.Responses being a map, we end up getting the services/operations in an inconsistent order when we have multiple responses. This makes some of the tests flaky (test 1 and test 2). One fix for that is just sorting the operations and services (done in this pr), though if we think that's too expensive (I don't think we should have that many of them?) we could also try to rework the tests, though considering that one of them involves checking a big json string that could either be a bit complex or just involve not using 2 responses (though that reduces the test coverage).
The other change was to avoid a seg fault in
TestProcessTraceListAndTraceSpansResponse, which was happening because the helper that generated the test queries used a map and was unordered. Changed to an array.Which issue(s) this PR fixes:
Fixes #368
Special notes for your reviewer: