Improve provisioning example in README.md #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided provisioning example were incomplete and erroneous. I merged them and documented them inline. This example is proven to be working. Removed the typographic quotes which are no valid yaml
schroedermatthias
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
|
|
idastambuk
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Hi @schroedermatthias thanks for the contribution, this looks good. And thank you for the patience with us getting to this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided provisioning example were incomplete and erroneous.
I merged them (not obivous why log access need different setup) and documented them inline.
This example is proven to be working.
What this PR does / why we need it:
Which issue(s) this PR fixes: